[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 14:24:51 PDT 2018


aheejin added a comment.

I agree using existing error handling mechanisms in AsmParser (and obj parser too) is better, but I don't think that should be included in this CL to be landed. Do assertions for this CL look fine? But if I use assertions, I don't seem to be able to add a test case. Can I commit that without the test?


Repository:
  rL LLVM

https://reviews.llvm.org/D53620





More information about the llvm-commits mailing list