[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 08:51:09 PDT 2018


dschuff added a comment.

I think catching block mismatch errors at parse time makes sense; although the third way that MCInst can be generated (aside from the compiler and asmparser) is the object file parser. So those checks would have to go both in the asm parser and object file parser. But if that means that we can hook into some existing error handling mechanism instead of using report_fatal_error, then it's probably worth it.
I agree that we can't use an assert string in a CHECK. The test wouldn't pass in a release non-asserts build (our release binaries have assertions, but it's not the default, and the official release binaries don't).


Repository:
  rL LLVM

https://reviews.llvm.org/D53620





More information about the llvm-commits mailing list