[PATCH] D53383: [PowerPC] Make no-PIC default to match GCC - LLVM

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 13:25:06 PDT 2018


stefanp added a comment.

Generally the way I decided on how to update the test depended on a couple of things:

1. If the test had this line: `; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py` it means that we had an auto generate test and if I felt that the test had nothing really to do with PIC or no-PIC I would just regenerate it.  For example a number of tests just had `addis` `ld` differences.
2. If the test was not auto generated but it still had nothing to do with PIC / no-PIC I would just add `-relocation-model=pic`. Changing these tests would not get us very much and it would be a significant amount of work.
3. For tests that had something to do with PIC / no-PIC I tried to make a judgement call as to what would be more useful to keep (the PIC test or the non-PIC test). If you feel that some of these tests I should have been the other way around let me know.  I know you mentioned a couple in your comment and I'll take a look at those.

The reason why it may look a little random is because of all of the `testCompare*` tests. I don't know why but it seems that some of those tests were auto-generated and some were not but they all have nothing to do with PIC.


https://reviews.llvm.org/D53383





More information about the llvm-commits mailing list