[PATCH] D53383: [PowerPC] Make no-PIC default to match GCC - LLVM

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 24 11:42:18 PDT 2018


jsji added a comment.

I am seeing two choices in the testcases you updated: one is adding -relocation-model=pic,  the other is to update code sequeces. 
What is your general rules to choose which one to do?

For those testcase updated with "-relocation-model=pic," do we know what might happen if default is no-PIC?

I am asking because it looks like the choice is kind of random (?).
Some may need more careful thoughts?

eg: maybe we should also check what happens with xray-tail-call-sled.ll for the new default?


https://reviews.llvm.org/D53383





More information about the llvm-commits mailing list