[PATCH] D41474: Fix a crash in lazy loading of Metadata in ThinLTO

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In https://reviews.llvm.org/D41474#1271879, @dexonsmith wrote:

> In https://reviews.llvm.org/D41474#1270703, @tejohnson wrote:
>
> > In https://reviews.llvm.org/D41474#1270284, @hiraditya wrote:
> >
> > > Can we land this patch
> >
> >
> > Let me take a look today. As noted in my earlier comment, this still seems like a hammer to fix something that was intended to be handled earlier by the MDLoader. I'd like to understand why it didn't work as intended.
>
>
> FWIW I'm concerned about this patch too.  I think we need to understand the issue (and as per Mehdi's comments, understand the exact structure leading to the issue) before committing a fix.


Quick note that I have been looking at this and have a rough idea of what is going on and another possible fix. Needs some more investigation tomorrow.


https://reviews.llvm.org/D41474