[PATCH] D41474: Fix a crash in lazy loading of Metadata in ThinLTO

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 22 19:43:55 PDT 2018


dexonsmith added a comment.

In https://reviews.llvm.org/D41474#1270703, @tejohnson wrote:

> In https://reviews.llvm.org/D41474#1270284, @hiraditya wrote:
>
> > Can we land this patch
>
>
> Let me take a look today. As noted in my earlier comment, this still seems like a hammer to fix something that was intended to be handled earlier by the MDLoader. I'd like to understand why it didn't work as intended.


FWIW I'm concerned about this patch too.  I think we need to understand the issue (and as per Mehdi's comments, understand the exact structure leading to the issue) before committing a fix.


https://reviews.llvm.org/D41474





More information about the llvm-commits mailing list