[PATCH] D53306: [X86] Stop promoting integer loads to vXi64
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 22 15:19:10 PDT 2018
craig.topper added a comment.
@sanjoy @sammccall I've recommitted this in r344965 with a fix for the miscompile. I believe DAGCombiner::ForwardStoreValueToDirectLoad was forwarding a v4i64 store to a v4i32 load by replacing them with a truncate which doesn't work for vectors. We would need an extract_subvector+bitcast. I've put in a qualification to only forward scalars if the types don't match. Please let me know if you see any more issues.
Repository:
rL LLVM
https://reviews.llvm.org/D53306
More information about the llvm-commits
mailing list