[PATCH] D52369: [tblgen][disasm] Allow multiple encodings to disassemble to the same instruction

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added inline comments.


================
Comment at: include/llvm/Target/Target.td:406-407
+
+  // List of predicates which will be turned into isel matching code.
+  list<Predicate> Predicates = [];
+
----------------
nhaehnle wrote:
> Is `Predicates` actually used? If no, better to leave it out for now. If yes, remove its definition from `Instruction`.
> Is Predicates actually used? If no, better to leave it out for now.

Yes, it's used in my out of tree target to control availability of an instruction encoding between different revisions of the ISA.

> If yes, remove its definition from Instruction.

Well spotted. I'll remove that when I commit. Aside from that does the patch look good to you?


Repository:
  rL LLVM

https://reviews.llvm.org/D52369