[PATCH] D53444: Support ARM_V4BX relocation

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:522
+    // No computation is needed.
+    break;
   default:
----------------
ruiu wrote:
> This is little weird that you can just ignore the relocation. Is this correct?
> 
Yes, it's correct to ignore it; it's just a marker to indicate there's a "bx rN" instruction at the given address.  (It can be used to implement a special linker mode which rewrites ARMv4T inputs to ARMv4.)


================
Comment at: test/ELF/Inputs/v4bx.yaml:1
+--- !ELF
+FileHeader:
----------------
ruiu wrote:
> Assembly is preferred over YAML. I'm not sure if you can express this file in .s, but if you can, please do. If you can't, YAML is fine though.
LLVM currently never generates R_ARM_V4BX relocations.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53444