[PATCH] D53444: Support ARM_V4BX relocation

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/ARM.cpp:522
+    // No computation is needed.
+    break;
   default:
----------------
This is little weird that you can just ignore the relocation. Is this correct?



================
Comment at: test/ELF/Inputs/v4bx.yaml:1
+--- !ELF
+FileHeader:
----------------
Assembly is preferred over YAML. I'm not sure if you can express this file in .s, but if you can, please do. If you can't, YAML is fine though.


================
Comment at: test/ELF/v4bx.s:10
+// CHECK: .text
+
----------------
Remove the trailing blank line.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53444