[PATCH] D53336: Stack Safety Analysis documentation

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: llvm/docs/Passes.rst:363
+variables can be considered safe from memory access bugs. The pass attaches
+``!stack-safe`` to such variables.
+
----------------
eugenis wrote:
> I think we should distinguish the analysis itself which simply lets you query safety of variables, and the wrapper pass that sets the metadata. The primary usage mode of this thing should be by query, not by metadata IMHO.
I just wanted to chime in and say that in the ThinLTO case I think we have to annotate allocas with metadata since the global analysis has to run before any transformations occur. That said, the interface can be as you said where we just hide the logic to check metadata or otherwise run the analysis.


Repository:
  rL LLVM

https://reviews.llvm.org/D53336