[PATCH] D53240: [WebAssembly] WebAssemblyLowerEmscriptenEHSjLj: use getter/setter for accessing tempRet0

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

I think what I was trying express was that the names setTempRet0/getTempRet0  are embedded in emscripten for both returning the high bits of an i64 function and for EH, so renaming them to two independent sets of functions would a non-trivial change to emscripten and asm2wasm as well as this pass.

This change simply decouples llvm from the implementation of setTempRet0/getTempRet0 , in the same way that I am aslo doing in binaryen: https://github.com/WebAssembly/binaryen/pull/1709.   I think are you suggesting that we do the same for the variables behind setThrew?   I wouldn't be against that but I don't see that same urgent needs since there are not conflicting implementations.


Repository:
  rL LLVM

https://reviews.llvm.org/D53240