[PATCH] D53240: [WebAssembly] WebAssemblyLowerEmscriptenEHSjLj: use getter/setter for accessing tempRet0

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

> I did a little more investigating and there it turns out that decouple EH from getTempRet/setTempRet would be difficult because __cxa_find_matching_catch JS function in emscripten uses setTempRet0. So it seems that for now anyway it makes sense keep these unified.

Not sure what you mean. That's the only place `setTempRet0` is used for EH and it was the reason this pass generated `setTempRet0` function for, which is also written in the comment. You sound like it was being used elsewhere in EH and now you've discovered it is also being used in `__cxa_find_matching_catch` so it is hard to separate variable names, which I don't understand.

And I still think treating only `__tempRet0` special is a bit weird. What I initially suggested was not imposing any getter/setter requirement for any variable (regardless of where they come from), but if we want to do that, maybe we should be consistent on all variables. If it's the case you want to go that route, maybe they can come from follow-up patches though.


Repository:
  rL LLVM

https://reviews.llvm.org/D53240