[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

i've been thinking about it - it seems to me that they will almost inevitably diverge, handleArgs contains too much ELF-specific stuff and, in turn, MachO will have MachO -specific logic (i.e. to modify MachO header and load commands), so at least now it seems to me that mixing them together will cause more confusion (and will be hard to maintain and reason about), rather than provide the benefits of code sharing (which are not guaranteed, the structure of MachO "internal representation" (similar to the existing class objcopy::elf::Object) will be kind of different and I'm not sure we want to bind ourselves to the interface of the class objcopy::elf::Object - it seems to be hard and complicated, but I'm open to listen other arguments, maybe I'm missing smth)


Repository:
  rL LLVM

https://reviews.llvm.org/D53311