[PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 16 15:36:36 PDT 2018

Previous message: [PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type
Next message: [PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rupprecht added a comment.

Shouldn't `handleArgs` at least stay in llvm-objcopy.cpp? It includes some ELF specific stuff that would need to be refactored out, but it seems like moving it to a separate file will cause divergence between handling of ELF/MachO files.


Repository:
  rL LLVM

https://reviews.llvm.org/D53311

Previous message: [PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type
Next message: [PATCH] D53311: [llvm-objcopy] Introduce dispatch mechanism based on input type
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list