[PATCH] D53149: [PDB] Better support for posix style paths in PDBs.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.

I agree with the direction, but please update the commit message to make it clear what the new expected behavior of our tools is. Basically, they should generate native paths unless we have command line flags telling us to do something else.



================
Comment at: lld/COFF/PDB.cpp:221-239
 // Visual Studio's debugger requires absolute paths in various places in the
 // PDB to work without additional configuration:
 // https://docs.microsoft.com/en-us/visualstudio/debugger/debug-source-files-common-properties-solution-property-pages-dialog-box
 static void pdbMakeAbsolute(SmallVectorImpl<char> &FileName) {
-  if (sys::path::is_absolute(FileName, sys::path::Style::windows))
+  if (sys::path::is_absolute(FileName))
     return;
   if (Config->PDBSourcePath.empty()) {
----------------
Please clean up these comments to make it clear that we have a new, simple rule for what we're doing: Creating absolute paths that work on the linker's host filesystem. If you want any other kind of behavior, the user should use /pdbsourcepath:.


https://reviews.llvm.org/D53149