[PATCH] D53149: [PDB] Better support for posix style paths in PDBs.

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

A couple of comments, but looks good otherwise.



================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.cpp:156
   llvm::SmallString<64> main_file = GetMainSourceFile(*cci);
-  llvm::sys::path::native(main_file, llvm::sys::path::Style::windows);
+  std::string s = main_file.str();
+  llvm::sys::path::native(main_file);
----------------
This looks unused


================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:533
   for (llvm::StringRef f : cci->m_file_list) {
-    FileSpec spec(f, false, FileSpec::Style::windows);
+    FileSpec::Style style =
+        f.startswith("/") ? FileSpec::Style::posix : FileSpec::Style::windows;
----------------
Is it possible that it would start with a letter? Like D:\ etc...


https://reviews.llvm.org/D53149