[PATCH] D52951: [lld] Add more complete support for the INCLUDE command.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 8 11:08:33 PDT 2018


ruiu added inline comments.


================
Comment at: test/ELF/linkerscript/memory-include.s:3
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: echo "MEMORY {                                  \
+# RUN:   ROM (rwx): ORIGIN = 0x1000, LENGTH = 0x100    \
----------------
Please construct a linker script file like this

  echo foo > %t.inc
  echo bar >> %t.inc
  echo baz >> %t.inc

the reason being that %t.inc will have newline characters this way. If you use line concatenation, all lines are concatenated into a single line, and if something goes wrong, its error message is hard to read because a line is too long.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52951





More information about the llvm-commits mailing list