[PATCH] D52951: [lld] Add more complete support for the INCLUDE command.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 8 03:18:28 PDT 2018
grimar added a comment.
Looks good!
A suggestion about the test is below.
I think you can write the tests as *.test (see `lld/test/ELF/linkerscript/implicit-program-header.test` for example).
Idea is to make tests containing large linker scripts input easier to read by avoiding using `echo` for them.
You can write the following line instead of asm code I think:
`# RUN: echo 'nop; .section .data,"aw"; .quad 0' | llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %t.o`
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D52951
More information about the llvm-commits
mailing list