[PATCH] D52965: [X86][AVX] Improve vXi64 UITOFP vXf64/vXf32 support (P38226/PR38970)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:2415
 
     SDValue And = DAG.getNode(ISD::AND, dl, MVT::i64, Op0,
          DAG.getConstant(UINT64_C(0xfffffffffffff800), dl, MVT::i64));
----------------
So this code was guaranteed unreachable due to the assert? Are we sure its correct for signed? That assert has been there since 2006 and Owen Anderson added the algorithm for __floatundidf in 2010. So this code might actually be a different version of unsigned handling.


Repository:
  rL LLVM

https://reviews.llvm.org/D52965