[PATCH] D52914: [WebAssembly] Added test for inline assembly roundtrip.

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 17:38:46 PDT 2018


aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/inline-asm-roundtrip.ll:53
+!1 = !{!"clang version 8.0.0 (trunk 343492) (llvm/trunk 343501)"}
+!2 = !{i32 117, i32 140, i32 165, i32 184}
----------------
aheejin wrote:
> sbc100 wrote:
> > Can you trip all this attribute stuff to keep the test nice and small?
> I usually delete all the attributes unless they are necessary for the current test, but maybe it's because I'm pedantic too
Oh, these are not attributes but debug info.. but anyway, maybe we need neither of them here


Repository:
  rL LLVM

https://reviews.llvm.org/D52914





More information about the llvm-commits mailing list