[PATCH] D52914: [WebAssembly] Added test for inline assembly roundtrip.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/inline-asm-roundtrip.ll:37
+
+define hidden i32 @main(i32 %argc, i8** nocapture readnone %argv) local_unnamed_addr #0 {
+entry:
----------------
sbc100 wrote:
> Hmm.. is main compiled by clang as hidden?   In any case, you can drop that for the test
Maybe `local_unnamed_addr` too


================
Comment at: test/CodeGen/WebAssembly/inline-asm-roundtrip.ll:53
+!1 = !{!"clang version 8.0.0 (trunk 343492) (llvm/trunk 343501)"}
+!2 = !{i32 117, i32 140, i32 165, i32 184}
----------------
sbc100 wrote:
> Can you trip all this attribute stuff to keep the test nice and small?
I usually delete all the attributes unless they are necessary for the current test, but maybe it's because I'm pedantic too


Repository:
  rL LLVM

https://reviews.llvm.org/D52914