[PATCH] D52831: [lit] Only return a found bash executable on Windows if it can understand Windows paths

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 13:55:20 PDT 2018


zturner added a comment.

To be clear, I never suggested we should treat cmd.exe as a valid choice of
external shell. What I meant was that the two supported configurations
should be:

1. (non-Windows or WSL) && bashExists: use external shell
2. everything else: use internal shell

Note that #2 definitely is supported from inside cmd.exe


https://reviews.llvm.org/D52831





More information about the llvm-commits mailing list