[PATCH] D52831: [lit] Only return a found bash executable on Windows if it can understand Windows paths

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 13:55:02 PDT 2018


To be clear, I never suggested we should treat cmd.exe as a valid choice of
external shell. What I meant was that the two supported configurations
should be:

1) (non-Windows or WSL) && bashExists: use external shell
2) everything else: use internal shell

Note that #2 definitely is supported from inside cmd.exe
On Thu, Oct 4, 2018 at 1:43 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> Running cmd.exe is probably even less supported than running bash. If
> someone is accidentally using execute_external=True, I'd prefer it if they
> kept using bash and not cmd. So, I'd stick with the first patch.
>
> There are only 111 instances of REQUIRES.*shell in the LLVM monorepo
> today. We should push all the remaining ones to invoke `sh -c ...` directly
> for the shell they need, and make the internal lit shell the default lit
> shell implementation everywhere. It'll simplify lit code and make tests
> more portable.
>
>
> https://reviews.llvm.org/D52831
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181004/985e09ca/attachment.html>


More information about the llvm-commits mailing list