[PATCH] D43515: More math intrinsics for conservative math handling

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7330
+    break;
+  }
+
----------------
There are a lot of comments on this, so I may have missed something. Take with a grain of salt...

I don't think these are correct. These can trap so can't be speculatively executed. They would need a chain.


https://reviews.llvm.org/D43515