[PATCH] D43515: More math intrinsics for conservative math handling

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7355
+  if (!IsChained)
+    Res = MorphNodeTo(Node, NewOpc, VTs, { Node->getOperand(0) });
+  else if (IsUnary)
----------------
craig.topper wrote:
> This doesn't copy the second argument to FP_ROUJND over does it?
No. It should.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6376
   SDValue Result;
-  if (FPI.isUnaryOp())
+  if (Opcode == ISD::STRICT_FP_ROUND || Opcode == ISD::STRICT_FP_EXTEND)
+    Result = DAG.getNode(Opcode, sdl, VTs, 
----------------
craig.topper wrote:
> Is this adding a second argument to STRICT_FP_EXTEND as well? I don't think the non-strict FP_EXTEND has two arguments.
Agreed. I'll fix it.


https://reviews.llvm.org/D43515