[PATCH] D52764: [Intrinsic] Add llvm.minimum and llvm.maximum instrinsic functions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 4 07:21:11 PDT 2018


aheejin added a comment.

Bit of formatting nits



================
Comment at: docs/LangRef.rst:11564
+'``llvm.minimum.*``' Intrinsic
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
----------------
One more ^ at the end


================
Comment at: docs/LangRef.rst:11602
+'``llvm.maximum.*``' Intrinsic
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
----------------
One more ^ at the end


================
Comment at: docs/LangRef.rst:11613
+
+      declare float     @llvm.maximum.f32(float  %Val0, float  %Val1l)
+      declare double    @llvm.maximum.f64(double %Val0, double %Val1)
----------------
- double whitespaces between `float` and `%Val1`
- stray `l` after `%Val1`


================
Comment at: docs/LangRef.rst:11615
+      declare double    @llvm.maximum.f64(double %Val0, double %Val1)
+      declare x86_fp80  @llvm.maximum.f80(x86_fp80  %Val0, x86_fp80  %Val1)
+      declare fp128     @llvm.maximum.f128(fp128 %Val0, fp128 %Val1)
----------------
double whitespaces between `x86_fp80` and `%Val0` / `x86_fp80` and `%Val1`


================
Comment at: docs/LangRef.rst:11617
+      declare fp128     @llvm.maximum.f128(fp128 %Val0, fp128 %Val1)
+      declare ppc_fp128 @llvm.maximum.ppcf128(ppc_fp128  %Val0, ppc_fp128  %Val1)
+
----------------
double whitespaces between `ppc_fp128` and `%Val0`  / `ppc_fp128` and `%Val1`


Repository:
  rL LLVM

https://reviews.llvm.org/D52764





More information about the llvm-commits mailing list