[PATCH] D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D50902#1250110, @filcab wrote:

> 0 only means “one of those two”, so I prefer your current patch then a
>  change to genericUB.
>
> Your reasoning is good, and I’m ok with having different constants.


Great to hear!

> Current patch almost LGTM:
> 
> - I have questions about the tests and why not support the standalone runtime.

Hm, i'm not sure what you mean.
This should support all the same things as the current monolithic Kind.

> - please add a mention that the 0 enumerator for the check kind was only emitted on llvm7.0

Yes, i will do that. I didn'd actually post the updated patch yet, i will.

> Thank you,
> 
>   Filipe




Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50902