[PATCH] D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a subscriber: aizatsky.
filcab added a comment.

0 only means “one of those two”, so I prefer your current patch then a
change to genericUB.

Your reasoning is good, and I’m ok with having different constants. Current
patch almost LGTM:

- I have questions about the tests and why not support the standalone

runtime.

- please add a mention that the 0 enumerator for the check kind was only

emitted on llvm7.0

Thank you,
Filipe


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50902