[PATCH] D52504: [DAGCombiner] Div/rem folds

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 05:02:34 PDT 2018


xbolva00 added inline comments.


================
Comment at: test/CodeGen/X86/pr38539.ll:6
 ; This test is targeted at 64-bit mode. It used to crash due to the creation of an EXTRACT_SUBREG after the peephole pass had ran.
 define void @f() {
 ; X64-LABEL: f:
----------------
RKSimon wrote:
> These test cases need rebuilding so that they still check for PR38539 
So change %B8 = srem i66 0, %B20 to e.g.
%B8 = srem i66 3 (any value which does not fold), %B20 should be okay?


https://reviews.llvm.org/D52504





More information about the llvm-commits mailing list