[PATCH] D52504: [DAGCombiner] Div/rem folds

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 02:31:03 PDT 2018


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/pr38539.ll:6
 ; This test is targeted at 64-bit mode. It used to crash due to the creation of an EXTRACT_SUBREG after the peephole pass had ran.
 define void @f() {
 ; X64-LABEL: f:
----------------
These test cases need rebuilding so that they still check for PR38539 


================
Comment at: test/CodeGen/X86/shrink_vmul.ll:2233
   store <9 x i32> %mul, <9 x i32>* undef, align 64
   ret void
 }
----------------
This test needs updating to still check for this bug - I'll try to fix this one


https://reviews.llvm.org/D52504





More information about the llvm-commits mailing list