[PATCH] D48276: [llvm-mca] Stricter checking from update_mca_test_checks.py

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 04:23:03 PDT 2018


gbedwell added a comment.

I've chatted with @andreadb and @RKSimon offline a bit.  It would be nice to try and avoid some of the obviously duplicated blocks in the tests.  For example, the added blocks in option-all-stats-1.s above.  That's not actually an issue related to this specific patch, and the generated tests are still valid, but sometimes look a bit messy.

I don't want to hold this patch up based on that, but on the other hand if I can come up with something quickly, it might make sense to land them at the same time to prevent too much churn.  I'll update when I know more.


https://reviews.llvm.org/D48276





More information about the llvm-commits mailing list