[PATCH] D48276: [llvm-mca] Stricter checking from update_mca_test_checks.py

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell marked an inline comment as done.
gbedwell added inline comments.


================
Comment at: utils/update_mca_test_checks.py:324-326
+      if block_text and not current_set:
+        raise Error(
+          'block not captured by existing prefixes:\n\n{}'.format(block_text))
----------------
lebedev.ri wrote:
> I'm not sure, is this related to the rest of the diff?
This is part of the same stricter checking.  It, for example, caught the issue in test/tools/llvm-mca/X86/option-all-stats-1.s where the following RUN commands were generating slightly different output, but without any differentiating check prefixes.

```
# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2 -all-stats=false < %s | FileCheck %s -check-prefix=ALL
# RUN: llvm-mca -mtriple=x86_64-unknown-unknown -mcpu=btver2                  < %s | FileCheck %s -check-prefix=ALL
```


https://reviews.llvm.org/D48276