[llvm] r342784 - Try moving this function to another file.

[David Blaikie via llvm-commits]

Could be handy to link to (and/or copy/paste) the compilation errors in the
commit message so other folks going back over this code/following along in
commit-mails can see what you're adressing/working around?

On Fri, Sep 21, 2018 at 4:01 PM Zachary Turner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: zturner
> Date: Fri Sep 21 16:00:37 2018
> New Revision: 342784
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342784&view=rev
> Log:
> Try moving this function to another file.
>
> I can't reproduce this compilation failure so I can't really
> test this fix.
>
> Modified:
>     llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
>     llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h?rev=342784&r1=342783&r2=342784&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h Fri Sep 21
> 16:00:37 2018
> @@ -37,13 +37,6 @@ enum class PdbSymbolIdField : uint32_t {
>    LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue = */ All)
>  };
>
> -template <typename T>
> -void dumpSymbolField(raw_ostream &OS, StringRef Name, T Value, int
> Indent) {
> -  OS << "\n";
> -  OS.indent(Indent);
> -  OS << Name << ": " << Value;
> -}
> -
>  void dumpSymbolIdField(raw_ostream &OS, StringRef Name, SymIndexId Value,
>                         int Indent, const IPDBSession &Session,
>                         PdbSymbolIdField FieldId, PdbSymbolIdField
> ShowFlags,
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h?rev=342784&r1=342783&r2=342784&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h Fri Sep 21 16:00:37
> 2018
> @@ -12,6 +12,8 @@
>
>  #include "llvm/DebugInfo/CodeView/CodeView.h"
>  #include "llvm/DebugInfo/PDB/PDBTypes.h"
> +#include "llvm/Support/raw_ostream.h"
> +
>  #include <unordered_map>
>
>  namespace llvm {
> @@ -42,6 +44,15 @@ raw_ostream &operator<<(raw_ostream &OS,
>  raw_ostream &operator<<(raw_ostream &OS, const VersionInfo &Version);
>  raw_ostream &operator<<(raw_ostream &OS, const TagStats &Stats);
>
> +
> +template <typename T>
> +void dumpSymbolField(raw_ostream &OS, StringRef Name, T Value, int
> Indent) {
> +  OS << "\n";
> +  OS.indent(Indent);
> +  OS << Name << ": " << Value;
> +}
> +
> +
>  } // end namespace pdb
>
>  } // end namespace llvm
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180924/0fa897ac/attachment.html>