<div dir="ltr">Could be handy to link to (and/or copy/paste) the compilation errors in the commit message so other folks going back over this code/following along in commit-mails can see what you're adressing/working around?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 21, 2018 at 4:01 PM Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Fri Sep 21 16:00:37 2018<br>
New Revision: 342784<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=342784&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=342784&view=rev</a><br>
Log:<br>
Try moving this function to another file.<br>
<br>
I can't reproduce this compilation failure so I can't really<br>
test this fix.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h<br>
    llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h?rev=342784&r1=342783&r2=342784&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h?rev=342784&r1=342783&r2=342784&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/PDB/IPDBRawSymbol.h Fri Sep 21 16:00:37 2018<br>
@@ -37,13 +37,6 @@ enum class PdbSymbolIdField : uint32_t {<br>
   LLVM_MARK_AS_BITMASK_ENUM(/* LargestValue = */ All)<br>
 };<br>
<br>
-template <typename T><br>
-void dumpSymbolField(raw_ostream &OS, StringRef Name, T Value, int Indent) {<br>
-  OS << "\n";<br>
-  OS.indent(Indent);<br>
-  OS << Name << ": " << Value;<br>
-}<br>
-<br>
 void dumpSymbolIdField(raw_ostream &OS, StringRef Name, SymIndexId Value,<br>
                        int Indent, const IPDBSession &Session,<br>
                        PdbSymbolIdField FieldId, PdbSymbolIdField ShowFlags,<br>
<br>
Modified: llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h?rev=342784&r1=342783&r2=342784&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h?rev=342784&r1=342783&r2=342784&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h (original)<br>
+++ llvm/trunk/include/llvm/DebugInfo/PDB/PDBExtras.h Fri Sep 21 16:00:37 2018<br>
@@ -12,6 +12,8 @@<br>
<br>
 #include "llvm/DebugInfo/CodeView/CodeView.h"<br>
 #include "llvm/DebugInfo/PDB/PDBTypes.h"<br>
+#include "llvm/Support/raw_ostream.h"<br>
+<br>
 #include <unordered_map><br>
<br>
 namespace llvm {<br>
@@ -42,6 +44,15 @@ raw_ostream &operator<<(raw_ostream &OS,<br>
 raw_ostream &operator<<(raw_ostream &OS, const VersionInfo &Version);<br>
 raw_ostream &operator<<(raw_ostream &OS, const TagStats &Stats);<br>
<br>
+<br>
+template <typename T><br>
+void dumpSymbolField(raw_ostream &OS, StringRef Name, T Value, int Indent) {<br>
+  OS << "\n";<br>
+  OS.indent(Indent);<br>
+  OS << Name << ": " << Value;<br>
+}<br>
+<br>
+<br>
 } // end namespace pdb<br>
<br>
 } // end namespace llvm<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>