[PATCH] D50923: [New PM][PassInstrumentation] IR printing support for New Pass Manager
Fedor Sergeev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 24 08:11:56 PDT 2018
fedor.sergeev added inline comments.
================
Comment at: tools/opt/NewPMDriver.cpp:221
+
+ PassBuilder PB(TM, P, &PIC);
registerEPCallbacks(PB, VerifyEachPass, DebugPM);
----------------
philip.pfaffe wrote:
> Why is this part of this particular change?
Our PassInstrumentation wrapper is capable of working with Callbacks == nullptr, and in that case it will essentially be no-op.
This change intends doing something real within default invocations of opt, so it intiializes PassBuilder with nontrivially initialized callbacks and that causes proper PassInstrumentationAnalyses being installed as part of the PassBuilder scrutiny.
Repository:
rL LLVM
https://reviews.llvm.org/D50923
More information about the llvm-commits
mailing list