[PATCH] D50923: [New PM][PassInstrumentation] IR printing support for New Pass Manager

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 07:21:00 PDT 2018


philip.pfaffe added a comment.

LGTM, but I wonder why the PIC object is set up and used only in this change. Did we miss that in the change introducing it?



================
Comment at: tools/opt/NewPMDriver.cpp:221
+
+  PassBuilder PB(TM, P, &PIC);
   registerEPCallbacks(PB, VerifyEachPass, DebugPM);
----------------
Why is this part of this particular change?


Repository:
  rL LLVM

https://reviews.llvm.org/D50923





More information about the llvm-commits mailing list