[PATCH] D51993: TableGen/CodeGenDAGPatterns: addPredicateFn only once

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D51993#1232426, @RKSimon wrote:

> In https://reviews.llvm.org/D51993#1232277, @nhaehnle wrote:
>
> > In https://reviews.llvm.org/D51993#1232208, @RKSimon wrote:
> >
> > > Any perf numbers? For instance, on x86 -gen-dag-isel
> >
> >
> > No, and I don't see why we'd care. The motivation was purely code cleanup, and I don't see how the performance could get worse.
>
>
> Curiosity - I've been trying very hard to reduce tablegen build times over the past few months.


Sounds great. In the mean time, however, I see no reason not to approve this patch. Seems like the performance would only get better.


Repository:
  rL LLVM

https://reviews.llvm.org/D51993