[PATCH] D46423: [WIP, RISCV] Support .option relax and .option norelax

[Lewis Revill via Phabricator via llvm-commits]

lewis-revill added a comment.

@asb from the implementation I think it would cover the case where the `-mrelax` flag is passed but `.option norelax` is added to the beginning of the file, as the `ForceRelocs` field is never set by `.option relax`. Thinking about this though does reveal a possible flaw in this implementation in that if `-mrelax` is passed, then after an instruction that may be relaxed, `.option norelax` is enabled, diff relocations won't be emitted after the `.option norelax`, even though to be safe they should be. I'll look into updating the implementation to act correctly in both cases when I get the chance. I might need to split the testcsae into two files to make sure both cases are covered.

Thanks


Repository:
  rL LLVM

https://reviews.llvm.org/D46423