[PATCH] D52304: [X86][BMI1]: X86DAGToDAGISel: select BEXTR from x & ~(-1 << nbits) pattern
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 20 08:59:21 PDT 2018
lebedev.ri updated this revision to Diff 166307.
lebedev.ri added a comment.
Use `ISD::ANY_EXTEND`. This gets rid of the extra `movzbl` of the `NBits`.
At least that is what https://reviews.llvm.org/D48768 already produced.
If `NBits` is larger than 64 (in 64-bit case), the shift was already undefined, i think?
Repository:
rL LLVM
https://reviews.llvm.org/D52304
Files:
lib/Target/X86/X86ISelDAGToDAG.cpp
test/CodeGen/X86/extract-bits.ll
test/CodeGen/X86/extract-lowbits.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52304.166307.patch
Type: text/x-patch
Size: 24430 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180920/c2c0a8a6/attachment.bin>
More information about the llvm-commits
mailing list