[PATCH] D52283: [PDB] Add the ability to resolve forward references

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 16:37:45 PDT 2018


I can probably also just use the pdb::HashTable class where the key is the
actual hash value. I’ll go with the vector first since it’s simple and
obviously correct then try to change it to something more efficient in a
followup
On Wed, Sep 19, 2018 at 4:23 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> In https://reviews.llvm.org/D52283#1239983, @zturner wrote:
>
> > It’s true that nested containers don’t usually perform well, but in this
> >  case the outer vector *never* resizes. So it seems like it should be ok?
>
>
> I'd be fine with the simple code, sure. We want the PDB to load fast,
> though, being cache friendly is the best way to do that, IMO. :)
>
>
> https://reviews.llvm.org/D52283
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180919/368037b7/attachment.html>


More information about the llvm-commits mailing list