[PATCH] D52283: [PDB] Add the ability to resolve forward references

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 16:23:45 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D52283#1239983, @zturner wrote:

> It’s true that nested containers don’t usually perform well, but in this
>  case the outer vector *never* resizes. So it seems like it should be ok?


I'd be fine with the simple code, sure. We want the PDB to load fast, though, being cache friendly is the best way to do that, IMO. :)


https://reviews.llvm.org/D52283





More information about the llvm-commits mailing list