[PATCH] D51942: [InstCombine] Fold (C/x)>0 into x>0 if possible

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 07:02:54 PDT 2018


spatel requested changes to this revision.
spatel added a comment.
This revision now requires changes to proceed.

I haven't had a chance to look at this closely, but a first glance says it only works for scalars even though it should provide identical functionality for vectors. 
Can you change the code to use the 'match()' API? This should substantially reduce the code and give you splat constant vector functionality for free (although there should be at least 1 test for that).


Repository:
  rL LLVM

https://reviews.llvm.org/D51942





More information about the llvm-commits mailing list