[PATCH] D51942: [InstCombine] Fold (C/x)>0 into x>0 if possible

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 04:54:43 PDT 2018


john.brawn accepted this revision.
john.brawn added a comment.
This revision is now accepted and ready to land.

LGTM. I think it may be possible to remove the hasAllowReciprocal check, because the point of that (as I understand it) is to allow converting a divide into a multiply-by-reciprocal in ways that can change the end result and I don't think that the transformation that's being done here will give a different result to the untransformed version, but I'm not certain of that and it's fine to leave it as it is.


Repository:
  rL LLVM

https://reviews.llvm.org/D51942





More information about the llvm-commits mailing list