[PATCH] D52220: [XRay][compiler-rt] FDRLogWriter Abstraction
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 18 05:45:26 PDT 2018
dberris added inline comments.
================
Comment at: compiler-rt/lib/xray/xray_fdr_log_writer.h:35
+ internal_memcpy(Buffer, P, Size);
+ SerializerImpl<Index + 1>::serializeTo(Buffer + Size, T);
+ }
----------------
mboerger wrote:
> Shouldn't this be: std::forward(T)
Good catch, yes!
https://reviews.llvm.org/D52220
More information about the llvm-commits
mailing list