[PATCH] D52220: [XRay][compiler-rt] FDRLogWriter Abstraction

Marcus Boerger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 05:20:11 PDT 2018


mboerger added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_fdr_log_writer.h:35
+    internal_memcpy(Buffer, P, Size);
+    SerializerImpl<Index + 1>::serializeTo(Buffer + Size, T);
+  }
----------------
Shouldn't this be: std::forward(T)


https://reviews.llvm.org/D52220





More information about the llvm-commits mailing list