[PATCH] D51207: Introduce llvm.experimental.widenable_condition intrinsic

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 08:05:19 PDT 2018


fedor.sergeev added inline comments.


================
Comment at: docs/LangRef.rst:15058
+
+This intrinsic represents "widenable conditions" which are
+boolean expressions with the following property: whether this
----------------
Plural form looks weird here. Single intrinsic represents a single condition...


================
Comment at: docs/LangRef.rst:15152
+  %widenable_condition = call i1 @llvm.experimental.widenable.condition()
+  %new_cond = and i1 %any_other_cond, %widenable_condition
+
----------------
without showing a use of %new_cond this additional instruction does not really change anything.
Since you show the same transform with %new_cond usage below I believe two code-blocks shown above can be deleted without sacrificing anything.


https://reviews.llvm.org/D51207





More information about the llvm-commits mailing list