[PATCH] D51969: [AMDGPU] Add an AMDGPU specific atomic optimizer.

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 03:09:38 PDT 2018


nhaehnle added a comment.

This still needs to be adjusted for https://reviews.llvm.org/D52087, and I have one minor comment, but mostly LGTM.



================
Comment at: lib/Target/AMDGPU/AMDGPUAtomicOptimizer.cpp:340
+    Instruction *const Ctpop =
+        B.CreateIntrinsic(Intrinsic::ctpop, Exec, nullptr, "");
+    Value *const CtpopCast = B.CreateIntCast(Ctpop, Ty, false);
----------------
The last two arguments are defaults, so you can just leave them out.


https://reviews.llvm.org/D51969





More information about the llvm-commits mailing list