[PATCH] D51984: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added subscribers: spatel, lebedev.ri.
lebedev.ri added a comment.

In https://reviews.llvm.org/D51984#1233755, @DiamondLovesYou wrote:

> In https://reviews.llvm.org/D51984#1233719, @beanz wrote:
>
> > If you add this to your patch here, the Clang patch should work as I've suggested:
> >
> >   diff --git a/cmake/modules/LLVM-Config.cmake b/cmake/modules/LLVM-Config.cmake
> >   index 8eabddc7377..a306e41f26d 100644
> >   --- a/cmake/modules/LLVM-Config.cmake
> >   +++ b/cmake/modules/LLVM-Config.cmake
> >   @@ -244,6 +244,9 @@ function(llvm_map_components_to_libnames out_libs)
> >              list(APPEND expanded_components "LLVM${t}Info")
> >            endif()
> >          endforeach(t)
> >   +    elseif( c STREQUAL "Polly")
> >   +      # LLVMPolly is the Polly loadable module target, the static archive is just Polly
> >   +      list(APPEND expanded_components "${c}")
> >        else( NOT idx LESS 0 )
> >          # Canonize the component name:
> >          string(TOUPPER "${c}" capitalized)
> >
> >
> > It is unfortunate that Polly doesn't match the naming conventions of other LLVM components, but we have a lot of special case handling for this kind of thing anyways.
>
>
> Thanks! I actually already had a similar patch ready to go, but the yelling from the buildbots distracted me (yikes; can't we have a rust-lang like process for this? Like buildbots first? It's pretty hard to get all this right everywhere... especially for a noob like me). I'll get that up on Phab Soon(TM).


On Thu, Sep 13, 2018 at 8:22 PM, Richard Diamond <wichard at vitalitystudios.com> wrote:

> On Thu, Sep 13, 2018 at 12:19 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:
> 
>> Richard, why are you making non-NFC cmake changes with no review all
>>  over the place?
> 
> I apologize. I was informed by Chris (beanz) that the `llvm-cfi-verify`/etc
>  changes could be pushed without review. The second patch was to fix an error
>  on my part (missing `intrinsics_gen` in a target's DEPENDS) which blew up
>  the bots.

@DiamondLovesYou i would *strongly* suggest that you read through 
https://llvm.org/docs/DeveloperPolicy.html
and
https://llvm.org/docs/Phabricator.html
a few times.


Repository:
  rL LLVM

https://reviews.llvm.org/D51984