[PATCH] D51984: Fixes for `LLVM_LINK_LLVM_DYLIB` && Polly.

[Richard Diamond via Phabricator via llvm-commits]

DiamondLovesYou abandoned this revision.
DiamondLovesYou added a comment.

In https://reviews.llvm.org/D51984#1233719, @beanz wrote:

> If you add this to your patch here, the Clang patch should work as I've suggested:
>
>   diff --git a/cmake/modules/LLVM-Config.cmake b/cmake/modules/LLVM-Config.cmake
>   index 8eabddc7377..a306e41f26d 100644
>   --- a/cmake/modules/LLVM-Config.cmake
>   +++ b/cmake/modules/LLVM-Config.cmake
>   @@ -244,6 +244,9 @@ function(llvm_map_components_to_libnames out_libs)
>              list(APPEND expanded_components "LLVM${t}Info")
>            endif()
>          endforeach(t)
>   +    elseif( c STREQUAL "Polly")
>   +      # LLVMPolly is the Polly loadable module target, the static archive is just Polly
>   +      list(APPEND expanded_components "${c}")
>        else( NOT idx LESS 0 )
>          # Canonize the component name:
>          string(TOUPPER "${c}" capitalized)
>
>
> It is unfortunate that Polly doesn't match the naming conventions of other LLVM components, but we have a lot of special case handling for this kind of thing anyways.


Thanks! I actually already had a similar patch ready to go, but the yelling from the buildbots distracted me (yikes; can't we have a rust-lang like process for this? Like buildbots first? It's pretty hard to get all this right everywhere... especially for a noob like me). I'll get that up on Phab Soon(TM).


Repository:
  rL LLVM

https://reviews.llvm.org/D51984